Vendor com.lihaoyi:::unroll-plugin:0.3.0#5431
Open
jackkoenig wants to merge 2 commits into
Open
Conversation
Bring unroll-plugin in tree so we can more easily cross-build against versions of Scala without waiting for upstream to publish. Imported from tag 0.3.0 (c9fd7e1ce9a92fe4ab15cd12fb61facc3aed8f2c). AI-assisted-by: OpenCode (GPT-5.4)
jackkoenig
added
the
Internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring unroll-plugin in tree so we can more easily cross-build against versions of Scala without waiting for upstream to publish.
Imported from tag 0.3.0 (c9fd7e1ce9a92fe4ab15cd12fb61facc3aed8f2c).
Unroll is not a particularly active repo (see com-lihaoyi/unroll#18), which is fine, but it does limit our ability to bump Scala. In particular, we'd like the Scala 3 port to bump to 3.3.8. We'd also like to test against newer versions of Scala (3.8.4 and 3.9.0-RC1). I'd especially like to be able to provide feedback on Scala release candidates as we will soon be in the position of caring about the latest 3.3 and eventually 3.9 releases.
I don't vendor code lightly, but unroll-plugin is also quite stable. Furthermore,
@unrollis a feature of Scala itself starting in 3.7 so once we bump to 3.9 (the next LTS) we can drop the use of this plugin and remove the code.Release Notes
Vendored implementation of
com.lihaoyi:::unroll-plugin. This is invisible to users because it is a compile-time dependency.Development notes