Draft
Conversation
Reason: it is easier to change when the master changes Files: build_flatpak.yml
Files: com.github.chipmuenk.pyfda.yaml and python3-requirements.json
chipmuenk
approved these changes
Dec 18, 2024
Owner
chipmuenk
left a comment
chipmuenk
left a comment
There was a problem hiding this comment.
This looks great, I'll test the build process later on in detail!
Contributor
Author
Perhabs it does not work yet. I have to fix an issue with the kiwi package |
Contributor
Author
Owner
|
I'm a bit confused about the state of this PR: Is it already ready for review / merge or are you working on it? There is no need to hurry, but I'm not sure whether I have to review / accept the changes. |
Contributor
Author
|
@chipmuenk I just created the Mr, but I am not yet finished. I will set it to ready once it is finished. If you prefer, I can also close it and reopen once finished? |
Owner
|
No, that's fine. I just wasn't sure whether an action was expected from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241