Resolves an issue where the path key is set to a different path if it…#629
Open
lovelgw wants to merge 12 commits intochimurai:masterfrom
Open
Resolves an issue where the path key is set to a different path if it…#629lovelgw wants to merge 12 commits intochimurai:masterfrom
lovelgw wants to merge 12 commits intochimurai:masterfrom
Conversation
… is duplicated in the URL path
Resolves an issue where the path key is set to a different path if it is duplicated in the URL path
ex >
{
'/product' : 'http://product-service/'
'/example' : 'http://product-service/'
}
call url : http://example.com/example/path/product
match route url : 'http://product-service/'
Owner
|
Thanks. |
another route key is use in url path test
Author
added unit test |
Snyk has created this PR to upgrade @types/http-proxy from 1.17.5 to 1.17.6. See this package in npm: See this project in Snyk: https://app.snyk.io/org/lovelgw/project/8d01a776-ebaf-4878-bab0-56d838168105?utm_source=github&utm_medium=upgrade-pr
…7694f5ce398 [Snyk] Upgrade @types/http-proxy from 1.17.5 to 1.17.6
Snyk has created this PR to upgrade @types/http-proxy from 1.17.6 to 1.17.7. See this package in npm: See this project in Snyk: https://app.snyk.io/org/lovelgw/project/8d01a776-ebaf-4878-bab0-56d838168105?utm_source=github&utm_medium=upgrade-pr
Snyk has created this PR to upgrade is-glob from 4.0.1 to 4.0.2. See this package in npm: See this project in Snyk: https://app.snyk.io/org/lovelgw/project/8d01a776-ebaf-4878-bab0-56d838168105?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade micromatch from 4.0.4 to 4.0.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/lovelgw/project/8d01a776-ebaf-4878-bab0-56d838168105?utm_source=github&utm_medium=referral&page=upgrade-pr
…64c7318ecb1 [Snyk] Upgrade @types/http-proxy from 1.17.6 to 1.17.7
…715bd491de3 [Snyk] Upgrade is-glob from 4.0.1 to 4.0.2
…3d4531d1d75 [Snyk] Upgrade micromatch from 4.0.4 to 4.0.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is duplicated in the URL path
Resolves an issue where the path key is set to a different path if it is duplicated in the URL path
ex >
{
'/product' : 'http://product-service/'
'/example' : 'http://example-service/'
}
call url : http://example.com/example/path/product
match route url : 'http://product-service/'
Motivation and Context
Found a problem as the route key was duplicated in the url path
How has this been tested?
Tested as a component currently under development
Types of changes
Checklist: