fix: prevent TypeError when ws enabled but server is undefined#1163
Open
bjnewman wants to merge 1 commit intochimurai:masterfrom
Open
fix: prevent TypeError when ws enabled but server is undefined#1163bjnewman wants to merge 1 commit intochimurai:masterfrom
bjnewman wants to merge 1 commit intochimurai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Hey! While working on #1162 (dropping Node 14/16/18), we ran into this issue and figured we'd fix it too.
The bug
When
ws: trueis enabled but the server object is undefined, trying to callcatchUpgradeRequest(server)crashes with:Happens with spdy/HTTP2, Bun, Deno, and some SSL setups.
The fix
Simple guard check before calling
catchUpgradeRequest:Tests
Added 6 edge case tests:
All 193 tests passing.
Thanks for maintaining this project!