fix(fixRequestBody): support content-encoding on request body#1142
Open
robbtraister wants to merge 2 commits intochimurai:masterfrom
Open
fix(fixRequestBody): support content-encoding on request body#1142robbtraister wants to merge 2 commits intochimurai:masterfrom
robbtraister wants to merge 2 commits intochimurai:masterfrom
Conversation
chimurai
reviewed
Sep 7, 2025
src/handlers/fix-request-body.ts
Outdated
| proxyData = zlib.gzipSync(proxyData); | ||
| break; | ||
| case 'zstd': | ||
| proxyData = zlib.zstdCompressSync(proxyData); |
Owner
There was a problem hiding this comment.
zlib.zstdCompressSync will throw in older Node versions:
Added in: v23.8.0, v22.15.0
https://nodejs.org/api/zlib.html#zlibzstdcompresssyncbuffer-options
Can you remove zstd support? since it is still experimental
Author
There was a problem hiding this comment.
sure thing. I noticed that body-parser only supports br, deflate, and gzip, but I thought might as well be more complete if possible. But I agree that better stability is more important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The body-parser package supports the
content-encodingheader on the request (See here). When reconstructing the body for proxied requests that have already been parsed, we should respect thecontent-encodingheader and preserve the original compression algorithm.Motivation and Context
Without this patch, an encoded request will fail when the upstream server attempts to read it due to a mismatch between the compression algorithm reported and the actual payload received. An alternative approach would be to remove the
content-encodingheader from the proxied request, but this seems more appropriate.How has this been tested?
I added a unit test to verify that the reconstructed body is encoded as expected.
Types of changes
Checklist: