Skip to content

chore(ci): Disable pytest coverage comment for forked PRs#80

Closed
effigies wants to merge 1 commit into
childmindresearch:mainfrom
effigies:ci/coverage-comment-forks
Closed

chore(ci): Disable pytest coverage comment for forked PRs#80
effigies wants to merge 1 commit into
childmindresearch:mainfrom
effigies:ci/coverage-comment-forks

Conversation

@effigies
Copy link
Copy Markdown
Contributor

Addresses the spurious test failure in #74.

Copy link
Copy Markdown
Collaborator

@gkiar gkiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaitj lmk if you have any issues here, seems fine to me.

@kaitj
Copy link
Copy Markdown
Contributor

kaitj commented May 20, 2026

Looks good to me. I'd suggest waiting to merge until we see if #77 addresses the issue. Asked @nx10 to take a quick look this morning and was going to test it out shortly.

@kaitj
Copy link
Copy Markdown
Contributor

kaitj commented May 20, 2026

Just tested out #77 from a fork and it looks like it should have fixed the commenting issue.

@effigies, could you rebase #74 one more time? If it is still running into that issue, then lets get this one merged in while we try to find another solution.

@effigies
Copy link
Copy Markdown
Contributor Author

Looks like it works now.

@effigies effigies closed this May 21, 2026
@effigies effigies deleted the ci/coverage-comment-forks branch May 21, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants