Fix StripPrefixError on windows when including templates#35
Merged
chevdor merged 2 commits intochevdor:masterfrom Feb 10, 2025
Merged
Fix StripPrefixError on windows when including templates#35chevdor merged 2 commits intochevdor:masterfrom
chevdor merged 2 commits intochevdor:masterfrom
Conversation
Owner
Contributor
Author
|
Sure. That should satisfy CI |
Contributor
Author
|
Regarding the flake, it seems to use rust 1.77.1, while lockfile v4 has been stabilized in 1.78.0. See rust-lang/cargo#14655 |
Owner
|
I created this issue: #36 |
Contributor
Author
|
Awesome thanks! |
Owner
|
Thanks for the PR, I am not using/testing Windows but happy to have it work there too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
My colleagues use windows and were surprised by an error when trying to include other templates.
I was able to track this down to the glob pattern creation logic, which has unix path separators hardcoded.
Simply using
Path.joininstead of the custom formatting seems to have resolved the issue for both of them.Thanks for this cli, its a simple solution for our simple problem!