fix: build using docker not working#539
Merged
algmyr merged 1 commit intocheran-senthil:masterfrom Jan 31, 2026
Merged
Conversation
cheran-senthil
approved these changes
Oct 11, 2025
Owner
cheran-senthil
left a comment
cheran-senthil
left a comment
There was a problem hiding this comment.
LGTM, can test on AC then merge!
Contributor
Author
Hey, Any updates? |
algmyr
reviewed
Jan 20, 2026
Collaborator
I think Cheran ended up forgetting about it. Can you fix the one comment I made and then I'll try prodding him to do the testing |
removed systemwide python dependencies installed using apt from the Dockerfile added extra dependencies to pyproject.toml to be installed using pip
7h3cyb3rm0nk
force-pushed
the
fix/docker-compose
branch
from
bbd506b to
fe988e1
Compare
Contributor
Author
|
Hey, any updates? |
algmyr
approved these changes
Jan 31, 2026
Collaborator
|
I guess I can't rely on him actually looking at stuff in a timely manner. Despite knowing roughly nothing about docker I was able to validate the fix and some other fixes. Merging now, thanks for your work and your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #538