Fix rich-inline punctuation boundary wrapping#194
Open
luyh7 wants to merge 1 commit into
Open
Conversation
|
If it's true that browsers behave exactly the same way for adjacent spans that they do for a single text node, it seems like doing this correctly would require a much bigger refactor so that all of the logic in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello+.stay attached.Why
Adjacent inline items should not introduce an extra line break before punctuation that browsers keep attached to the previous text node. This addresses #177.
Validation
/home/luyh7/tmp/.tools/bun-1.3.14/package/bin/bun test src/layout.test.tsnode node_modules/typescript/bin/tsc --noEmitnode node_modules/typescript/bin/tsc -p tsconfig.build.jsongit diff --check