Open
Conversation
Owner
|
Thanks for the PR! However, since this is a temporary workaround until proper async entry point is implemented, I'm not very keen on merging it. But lets keep it open so people have something to patch in the meantime. Tip for anyone wanting to use this (add to Cargo.toml): [patch.crates-io]
wasm_thread = { git = "https://github.com/vizigr0u/wasm_thread", rev = "90c7f2b", features = ["keep_worker_alive"] } |
Author
Thank you, this is very useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #18 is being discussed, this PR addresses one point which is only about closing the worker after the wasm entry point call.
This allows calling methods such as
request_animation_frame,set_intervaletc.The responsibility to close the worker is passed to the user, with the helper function
close_current_web_worker