Add performance cops and resource matching helper

[LohithR22]

Description

This PR introduces multiple enhancements to Cookstyle focused on improving CPU and memory efficiency, as well as enhancing code maintainability through shared abstractions.

🚀 New Performance Cops Added

• RepeatedResourcesInLoops
  Detects creation of batchable Chef resources (e.g., package, user, service) inside Ruby loops (e.g., .each), encouraging use of array resource declarations instead. This reduces unnecessary resource duplication and improves Chef client execution speed.

• LoadAllDataBagItems
  Flags overly broad or empty search and data_bag_search queries (e.g., "*:*" or "") that can result in loading all data bag items into memory, causing high memory usage and increased IO. Promotes more selective querying to improve performance.

🛠 Refactoring & Code Reuse

• Introduced a shared helper module:
  lib/rubocop/cop/chef/helpers/resource_matcher.rb, providing reusable AST detection methods:

  • search_call?
  • batchable_resource?
  • includes_guard?
  • node_is_chef_resource?

• Applied this helper in:

  • Newly created cops: RepeatedResourcesInLoops, LoadAllDataBagItems
  • Existing cop: ExecuteAptUpdate

This makes the cops cleaner, DRY, and more maintainable.

📚 Documentation

• Added a performance cops documentation file under docs-chef-cops/performance.md with:

  • Explanation of the performance department's goal
  • Details and examples for the newly introduced cops

✅ Testing

• Added RSpec tests for the two new performance cops.
• Added unit tests for the ResourceMatcher helper methods.
• Confirmed all existing and new tests pass successfully.

---

Related Issue

No specific GitHub issue linked.
This PR adds new functionality and internal improvements targeting Chef client performance optimization in community cookbooks.

---

Types of Changes

• ✨ New feature (non-breaking change which adds functionality)
• 🔧 Chore (non-breaking change that refactors or improves internal code/documentation)

---

Checklist

• I have read the CONTRIBUTING document
• I have run all pre-merge tests locally using bundle exec rspec
• I have updated documentation as required (performance.md, helpers.md)
• I have added/updated tests to cover my changes
• I have signed all commits for [the Developer Certificate of Origin]
• I have verified no unintended Gemfile.lock changes exist
• I have confirmed that all RuboCop cops are registered properly, and the .rubocop.yml is valid

---

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jaymzh]

only the package resource actually supports arrays the way you're implying.

And there is already a cop for that, UseMultipackageInstalls.

[jaymzh]

We picked one cop to review, we will come back and review others.

However, we encourage you to split up PRs into a single Cop each.

[jaymzh]

@LohithR22 are you still interested in working on this?