Add Chef/BestPractice/HardcodedPortNumbers cop

[Dhyanms]

Description

This PR adds a new cop Chef/BestPractice/HardcodedPortNumbers that
detects hardcoded port numbers in Chef cookbooks and suggests using
node attributes instead.

Motivation

Hardcoding port numbers reduces flexibility and makes it difficult to
reconfigure applications across different environments. Node attributes
provide a cleaner approach to port management that allows configuration
without code changes.

Implementation

• Detects integers in the dynamic port range (1024-65535)
• Skips very small numbers (1-1023) to avoid false positives
• Includes comprehensive test coverage with 5 test cases

Examples

Incorrect

service 'nginx' do
  port 8080
  action :start
end

Correct

service 'nginx' do
  port node['myapp']['port']
  action :start
end

Testing

All 5 tests pass:

• ✅ Detects hardcoded ports 8080 and 5432
• ✅ Doesn't flag node attributes
• ✅ Doesn't flag small numbers (1, 2, 3)
• ✅ Detects ports in service resources
• ✅ Works with real cookstyle validation

Checklist

• Code follows Cookstyle conventions
• Tests are comprehensive and passing
• Configuration added to enable cop
• Documentation/error messages are clear
• No regressions or breaking changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tas50]

The idea here is really neat, but I think you want to approach it a different way so it's less likely to produce false positives. First I'd highly suggest this be an opt-in cop that's off by default. It's useful for publishing community cookbooks, but probably less helpful for a lot of internal teams that are very confident in their port usage. Secondly I'd update this to look for properties call "port" and then flag and int value from there. That's going to require quite a bit more complex AST parsing of the cookbook, but it'll avoid a huge number of false positives that will happen otherwise.

[jaymzh]

As Tim said, lets make this opt in