Make the outputted "code generated" comment compatible with go generate#60
Open
NMFR wants to merge 2 commits into
Open
Make the outputted "code generated" comment compatible with go generate#60NMFR wants to merge 2 commits into
NMFR wants to merge 2 commits into
Conversation
…ate` manual Go generate manual (`go help generate`) states: ``` To convey to humans and machine tools that code is generated, generated source should have a line early in the file that matches the following regular expression (in Go syntax): ^// Code generated .* DO NOT EDIT\.$ ```` This change modifies the generated header comment to match the description of Go generate manual.
NMFR
changed the title
go generate manualgo generate
NMFR
changed the title
go generate
xiegeo
approved these changes
Sep 20, 2019
xiegeo
left a comment
xiegeo
left a comment
There was a problem hiding this comment.
Unless someone is depending on the old comment header, which they should not. I don't see why not.
Author
|
Anything missing on my side to get this merged? |
Contributor
|
any movement on this? |
Contributor
|
@xiegeo any reason why this can't be merged? |
Contributor
|
this resolves #63 |
|
@ghostsquad Sorry, I'm not a maintainer of this project so I don't have merging powers. I was doing a bunch of reviews requested and thought this was one of them. @pdrum is the most recent maintainer that I know of. |
Contributor
|
Sad when valuable OSS projects go "dark". I had to start a release on my own fork until this is merged. Maybe it's time to look for a new owner? @pdrum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go generate manual (
go help generate) states:This change modifies the generated header comment to match the description of go generate manual.