Skip to content

minor : Cleared Right Curly Errors#377

Open
MiriyalaJayanth-19 wants to merge 1 commit intocheckstyle:masterfrom
MiriyalaJayanth-19:pf4
Open

minor : Cleared Right Curly Errors#377
MiriyalaJayanth-19 wants to merge 1 commit intocheckstyle:masterfrom
MiriyalaJayanth-19:pf4

Conversation

@MiriyalaJayanth-19
Copy link
Contributor

When i ran checkstyle on patch-filters i got 321 violations . I will solve each of them in separte pr . In this i created a temporary .xml file to check only right curly errors for it to pass. There were 321 violations when i ran mvn checkstyle:check. After the changes made the violations are 300.

C:\Users\Jayanth Miriyala\projects\patch-filters>mvn checkstyle:check -Dcheckstyle.config.location=rightcurly-only.xml
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[INFO]
[INFO] -----------------< com.puppycrawl.tools:patch-filters >-----------------
[INFO] Building patch-filters 1.4.1-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- checkstyle:3.2.0:check (default-cli) @ patch-filters ---
[INFO] There are 7 errors reported by Checkstyle 10.4 with rightcurly-only.xml ruleset.
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionJavaPatchFilter.java:[212,17] (extension) RightCurlySame: '}' at column 17 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionJavaPatchFilter.java:[216,13] (extension) RightCurlySame: '}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionJavaPatchFilter.java:[242,9] (extension) RightCurlySame: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionPatchFilter.java:[143,17] (extension) RightCurlySame: '}' at column 17 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionPatchFilter.java:[147,13] (extension) RightCurlySame: '}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionPatchFilter.java:[169,9] (extension) RightCurlySame: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[ERROR] src\main\java\com\puppycrawl\tools\checkstyle\filters\SuppressionPatchFilterElement.java:[112,9] (extension) RightCurlySame: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  13.214 s
[INFO] Finished at: 2026-03-26T12:12:55+05:30
[INFO] ------------------------------------------------------------------------

After changes:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.894 s
[INFO] Finished at: 2026-03-26T12:27:05+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (default-cli) on project patch-filters: 
You have 300 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@MiriyalaJayanth-19
Copy link
Contributor Author

I think the failing ci is due to dependency . There's already a pr open dependency update could you please merge that and re-run the ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant