Open
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-651-amd64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: Cursor AI
What does this PR do?
This change fixes the publish job in
.github/workflows/image-publish.ymlfailing after merges to main.The workflow was calling
docker manifest annotateforamd64-*andarm64-*source tags. Those source tags are now manifest lists, and annotate fails with:<image>:amd64-<tag> is a manifest list.Since platform metadata is already present from the Buildx
--platform ... --pushflow, explicit annotation is no longer needed. The publish step now relies ondocker manifest create --amend ... --amend ...followed bydocker manifest push, which is compatible with current source image format.What issues does this PR fix?
eclipse-che/che#23745
How to test this PR?
quay.io/che-incubator/che-code:next
quay.io/che-incubator/che-code:insiders
quay.io/che-incubator/che-code:insiders-<short_sha>
Check manifest command:
podman manifest inspect quay.io/che-incubator/che-code:nextDoes this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder