Added composite command support and test coverage by msivasubramaniaan · Pull Request #639 · che-incubator/che-code

msivasubramaniaan · 2026-01-28T13:22:10Z

What does this PR do?

This PR supports to run the composite commands in terminal

What issues does this PR fix?

eclipse-che/che#21859
eclipse-che/che#23726
eclipse-che/che#23709
eclipse-che/che#23725

How to test this PR?

Added workspace which has all commands of devfile. Run those commands from devfile.yaml.

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

github-actions · 2026-01-28T13:22:21Z

Click here to review and test in web IDE:

code/extensions/che-commands/package-lock.json

github-actions · 2026-01-30T13:34:25Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

rgrunber · 2026-01-30T15:43:44Z

code/extensions/che-commands/src/taskProvider.ts

+
+				// Single-component → join commands
+				const joiner = parallel ? " & " : " && ";
+				let compositeCmd = execs.map((e) => e.commandLine).join(joiner);


@RomanNikitenko , is string manipulation the only way to do this ? Using compound tasks on the vscode side still isn't possible ?

I investigated that area more than 2 years ago, so I asked @msivasubramaniaan to double check that option when he started to work on the issue.
@msivasubramaniaan could you provide result of your investigation?

I double-checked this again.

At the moment, yes — string manipulation is still the only practical way to achieve this.

VS Code does not support dynamically creating or chaining compound tasks programmatically from an extension. Compound tasks must be statically defined in tasks.json, and there’s no API to generate or invoke a compound task on the fly based on resolved components or runtime data.

Because of that limitation, joining commands using && / & (depending on parallel vs sequential execution) remains the only viable solution when the task needs to be assembled dynamically.

So the approach of building a composite command string is the only way

RomanNikitenko

@msivasubramaniaan
I tried to test the functionality using your samples
I run component-parallel-demo command:

My understanding - it should run signal-frontend in the frontend container and signal-backend in the backend container.

Actual behaviour:

there is no output for both commands, for both containers
there is just message "Composite multi-component execution completed" which comes from the taskProvider https://github.com/che-incubator/che-code/pull/639/changes#diff-e505171c2bbd2db1494bbb49e7c7ccaad44644b923a12f6c5ca2ebdedd0fdbcdR389

Moreover, the dependent commands just hanging without any output when I run them separately:

Could you clarify:

what is expected behaviour there?
is it possible to detect which component is used for your test commands?
If commands are in the running state - why composite command reports that Composite multi-component execution completed?

thanks in advance!

RomanNikitenko · 2026-02-02T21:24:19Z

@msivasubramaniaan
I've prepared own sample and tested parallel and sequential uses cases for 2 components, I can confirm - it does not work, there is a bug - no output for both dependent commands and it's unclear if the commands are executed at all:

RomanNikitenko · 2026-02-02T21:35:21Z

@msivasubramaniaan
I've detected one more bug : a command label should be displayed instead of id:

RomanNikitenko · 2026-02-05T11:53:55Z

@msivasubramaniaan
I see you've requested a new review, but image for testing is not ready.
Please let me know when you test all use cases we discussed and regressions are fixed.
Thanks!

github-actions · 2026-02-05T12:24:23Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-05T15:05:22Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-05T16:49:11Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-05T19:50:14Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-11T23:18:21Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-12T07:13:54Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-12T08:36:25Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-12T10:54:36Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

msivasubramaniaan · 2026-02-12T11:32:55Z

Hello @RomanNikitenko

As discussed, the PR is ready for composite commands. I've tested with various cases and confirmed that all cases were working. Here is the proof for sequential flow with cross component

But still facing the issue with parallel flow of cross component. Due to PTY limitation on Devspaces the output got mixed.

if needed we can raise separate issue for track

RomanNikitenko

As discussed, the PR is ready for composite commands. I've tested with various cases and confirmed that all cases were working. Here is the proof for sequential flow with cross component

sorry, but sequential flow with cross component does not work correctly

let's say a user need to build a project first and then run it
let's say the build process takes some time
all this time a user has no output for the build process
it shows the output when the first task is completed only
but then there is another bug: a user has no output for the second task
again - it shows the output when a user stops the second task

Please see a short video.

I created a simple task that prints logs every second to simulate a long running task (like build)
First I run that regular task to show how it works
then - I run a composite task

composite.long.task.bug.mp4

github-actions · 2026-02-16T14:02:08Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-16T17:45:36Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-17T08:07:45Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

msivasubramaniaan · 2026-02-17T09:38:37Z

As discussed, the PR is ready for composite commands. I've tested with various cases and confirmed that all cases were working. Here is the proof for sequential flow with cross component

sorry, but sequential flow with cross component does not work correctly

let's say a user need to build a project first and then run it

let's say the build process takes some time

all this time a user has no output for the build process

it shows the output when the first task is completed only

but then there is another bug: a user has no output for the second task

again - it shows the output when a user stops the second task

Please see a short video.

I created a simple task that prints logs every second to simulate a long running task (like build)

First I run that regular task to show how it works

then - I run a composite task

composite.long.task.bug.mp4

Hello @RomanNikitenko
I wanted to know that both tasks are using same component or different component? When I checked with same component it is working as expected. Please share the devfile if possible.

PR-639.mp4

RomanNikitenko · 2026-02-17T12:51:09Z

Hello @RomanNikitenko I wanted to know that both tasks are using same component or different component? When I checked with same component it is working as expected. Please share the devfile if possible.

Hello @msivasubramaniaan!

Let's go through our discussion step by step:

you wrote "Here is the proof for sequential flow with cross component" in the Added composite command support and test coverage #639 (comment)
you added a screenshot with the Sequential: Check echo ubi8-ubi9 command to confirm - it works for different components
I answered with the message "sorry, but sequential flow with cross component does not work correctly"
I provided a video to report that the functionality does not work for sequential long-running composite commands with different components

So - I meant different components.
I'm sorry if I misunderstood your initial comment with the screenshot.

github-actions · 2026-02-17T14:40:47Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-17T17:33:24Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

msivasubramaniaan · 2026-02-17T17:40:19Z

Hello @RomanNikitenko I wanted to know that both tasks are using same component or different component? When I checked with same component it is working as expected. Please share the devfile if possible.

Hello @msivasubramaniaan!

Let's go through our discussion step by step:

you wrote "Here is the proof for sequential flow with cross component" in the Added composite command support and test coverage #639 (comment)

you added a screenshot with the Sequential: Check echo ubi8-ubi9 command to confirm - it works for different components

I answered with the message "sorry, but sequential flow with cross component does not work correctly"

I provided a video to report that the functionality does not work for sequential long-running composite commands with different components

So - I meant different components. I'm sorry if I misunderstood your initial comment with the screenshot.

@RomanNikitenko I have fixed the issue. Now user can able to see the logs.

RomanNikitenko

@RomanNikitenko I have fixed the issue. Now user can able to see the logs.

I tested that use case again and can confirm - it's fixed.
Thank you!

Within testing that use case I detected another problem:

it's not possible to stop a composite task using Ctrl+C or button on a command item
processes are hanging for long running commands even after using Kill button on UI
so - no command item on UI, but the corresponding process continue to work/is hanging

Please see this video:

Stop.command.bug.mp4

github-actions · 2026-02-18T13:44:25Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

github-actions · 2026-02-19T19:12:10Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-639-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-639-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-639-dev-amd64

msivasubramaniaan · 2026-02-19T20:15:33Z

@RomanNikitenko I have fixed the issue. Now user can able to see the logs.

I tested that use case again and can confirm - it's fixed. Thank you!

Within testing that use case I detected another problem:

it's not possible to stop a composite task using Ctrl+C or button on a command item

processes are hanging for long running commands even after using Kill button on UI

so - no command item on UI, but the corresponding process continue to work/is hanging

Please see this video:

Stop.command.bug.mp4

Hello @RomanNikitenko
I can handle the both case of terminating the process. Please refer the screenshot:

assisted-by: chatgpt-5 Added composite command support and test coverage

65b8e90

msivasubramaniaan requested review from RomanNikitenko, azatsarynnyy and vitaliy-guliy as code owners January 28, 2026 13:22

Merge branch 'main' into feat-add-composite-command-support

cb07f92

RomanNikitenko reviewed Jan 30, 2026

View reviewed changes

code/extensions/che-commands/package-lock.json Outdated Show resolved Hide resolved

resolved the license check issue

880d2ca

msivasubramaniaan requested a review from rgrunber as a code owner January 30, 2026 12:12

Merge branch 'main' into feat-add-composite-command-support

eb6c564

msivasubramaniaan requested a review from RomanNikitenko January 30, 2026 12:20

rgrunber reviewed Jan 30, 2026

View reviewed changes

RomanNikitenko reviewed Feb 2, 2026

View reviewed changes

msivasubramaniaan and others added 3 commits February 5, 2026 14:05

added label support and added execution part

4880d44

updated test cases

0eaf568

Merge branch 'main' into feat-add-composite-command-support

b91d813

msivasubramaniaan requested review from RomanNikitenko and rgrunber February 5, 2026 11:13

msivasubramaniaan marked this pull request as draft February 5, 2026 11:44

fixed the logic of execution

7572aaa

logic and test cases updated

fd06d92

logs were added

746b125

make parallel output in order

10ac1f2

resolving the emitter logic

d594c36

make final ready code

11b2e69

msivasubramaniaan marked this pull request as ready for review February 12, 2026 11:27

RomanNikitenko reviewed Feb 13, 2026

View reviewed changes

msivasubramaniaan force-pushed the feat-add-composite-command-support branch from cccbcd4 to 11b2e69 Compare February 17, 2026 07:12

emitting the data each time

0da25fe

refactor the data

af99c75

msivasubramaniaan requested a review from RomanNikitenko February 17, 2026 17:39

msivasubramaniaan added 2 commits February 17, 2026 23:33

Merge branch 'main' into feat-add-composite-command-support

8bd5a2b

Merge branch 'main' into feat-add-composite-command-support

18a5979

RomanNikitenko reviewed Feb 18, 2026

View reviewed changes

addressed close events

a4eb13e

msivasubramaniaan requested a review from RomanNikitenko February 19, 2026 20:15

Comments

Conversation

msivasubramaniaan commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

rgrunber Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

RomanNikitenko Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

msivasubramaniaan Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

RomanNikitenko left a comment

Choose a reason for hiding this comment

Uh oh!

RomanNikitenko commented Feb 2, 2026

Uh oh!

RomanNikitenko commented Feb 2, 2026

Uh oh!

RomanNikitenko commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

msivasubramaniaan commented Feb 12, 2026

Uh oh!

RomanNikitenko left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

msivasubramaniaan commented Feb 17, 2026

Uh oh!

RomanNikitenko commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

msivasubramaniaan commented Feb 17, 2026

Uh oh!

RomanNikitenko left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

msivasubramaniaan commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading

RomanNikitenko commented Feb 5, 2026 •

edited

Loading

RomanNikitenko left a comment •

edited

Loading

RomanNikitenko commented Feb 17, 2026 •

edited

Loading

RomanNikitenko left a comment •

edited

Loading