fix #34 again #53
Open
fix #34 again #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #34
shape.BoundBox has incorrect values in CurvedSegments, since the
shapehas been newly generated but not been displayed yet (not tessellated) instead of tesselating the shape, we call optimalBoundingBox which computes the dimensions without relying on Tessellationthis should ideally be done everywhere in the code, but optimalBoundingBox has slightly different return than BoundBox does which causes issues with some operations (nearly one-dimensional ribs, etc...) since even flat shapes can up to 2*epsilon thickness reported depending on OCCT version
in this place it is absolutely needed because otherwise curvedsegments are badly broken