Added preferred height#129
Open
kombatkos wants to merge 3 commits into
Open
Conversation
chausovSurfStudio
requested changes
Mar 21, 2022
|
|
||
| // MARK: - Public Properties | ||
|
|
||
| public var preferredHeight: CGFloat? |
There was a problem hiding this comment.
предложил бы переименовать в preferredTextHeight
(типа что именно TEXT height, а то там этих настроек высоты уже столько, что черт ногу сломит 😢 )
There was a problem hiding this comment.
и комментов подлить, зачем, почему и к чему приведет
| } | ||
|
|
||
| textViewHeightConstraint.constant = textHeight | ||
| textViewHeightConstraint.constant = preferredHeight ?? textHeight |
There was a problem hiding this comment.
а вот это вот не уверен, что совсем верно
textheight участвует в вычислении actualViewHeight -> надо бы подменить до того, как она будет еще где-то использована, по идее - в строке
let textHeight = min(textViewHeight(), maxTextContainerHeight ?? CGFloat.greatestFiniteMagnitude)это сделать можно
There was a problem hiding this comment.
а то может привести к какому-то такому результату
Collaborator
Author
There was a problem hiding this comment.
Проверил на проекте и на тимплейтах, все работает!
2022-03-21.22.42.18.mov
2022-03-21.22.36.20.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано:
Когда это нужно