Improve union-types serialization#6
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix serialization of MuteDuration variants for RPC
Fix discriminated union variant structs always serializing kind as empty string
Mar 4, 2026
adbenitez
force-pushed
the
copilot/fix-mute-duration-serialization
branch
from
25efbc6 to
257e56a
Compare
adbenitez
changed the title
adbenitez
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant structs like
MuteDurationNotMutedincludedKind stringas a regular Go field. Since the zero value ofstringis"",&MuteDurationNotMuted{}would marshal as{"kind":""}instead of{"kind":"NotMuted"}, requiring users to manually set theKindfield to the proper value.Changes
generate_variant_struct: Excludes thekindfield from struct properties (it's a discriminator, not user data) and adds aMarshalJSONmethod per variant that always injects the correctkindvalue using thealiaspattern to avoid infinite recursion.TypeGenerator: Addshas_union_types()method.types.go.j2: Extends theencoding/jsonimport condition to trigger when union types exist (since the newMarshalJSONusesjson.Marshal).