Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK to use new ChartMogul API endpoints for connecting and disconnecting customer subscriptions. The changes introduce new methods in ChartMogul::Metrics::Customers::Subscription while deprecating the existing methods in ChartMogul::Subscription.
Key changes:
- Added
connectanddisconnectmethods toChartMogul::Metrics::Customers::Subscriptionthat use the new API format withdata_source_uuidparameter - Deprecated the existing
connectanddisconnectmethods inChartMogul::Subscriptionwith warning messages - Added test coverage for the new connect/disconnect functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/fixtures/vcr_cassettes/ChartMogul_Metrics_Customers_Subscription/should_connect_and_disconnect_subscriptions_.yml | VCR cassette recording API interactions for testing connect/disconnect functionality |
| spec/chartmogul/metrics/customers/subscriptions_spec.rb | New test case for connect and disconnect operations |
| lib/chartmogul/subscription.rb | Added deprecation warnings to existing connect and disconnect methods |
| lib/chartmogul/metrics/customers/subscription.rb | Implemented new connect and disconnect methods with data_source_uuid parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
swember
approved these changes
Dec 29, 2025
pkopac
approved these changes
Jan 2, 2026
wscourge
deleted the
wiktor/ome-417-add-support-for-subscription-connections-via
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the SDK to use the new API endpoints:
ChartMogul::Metrics::Customers::Subscription#connectChartMogul::Metrics::Customers::Subscription#disconnectMark the following methods as deprecated:
ChartMogul::Subscription#connectChartMogul::Subscription#disconnect