Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates CustomerSubscription.list_imported() in favor of a new Customer.subscriptions() method and updates documentation examples to use correct field names.
- Adds new
Customer.subscriptions()method for retrieving customer subscriptions - Marks
CustomerSubscription.list_imported()as deprecated with a warning - Corrects field names from
external_idtouuidin subscription connection examples
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chartmogul/api/customer.py | Adds new Customer.subscriptions() method |
| chartmogul/api/customers/subscription.py | Implements deprecation warning for list_imported() method |
| test/api/test_customer.py | Adds test coverage for new subscriptions() method and updates field names in existing tests |
| README.md | Documents new subscriptions() method and corrects field names in examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loomchild
reviewed
Dec 31, 2025
loomchild
left a comment
There was a problem hiding this comment.
Overall, LGTM, but I have some trouble testing it. Please provide testing instructions and which environment to use.
pkopac
approved these changes
Jan 1, 2026
264a4ad to
899c842
Compare
loomchild
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscription.list_imported()methodCustomerSubscriptionimport to customer module