Add fetching additional DataSource fields#147
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for fetching additional DataSource fields (processing_status, auto_churn_subscription_setting, and invoice_handling_setting) when listing or retrieving data sources via query parameters.
Key changes:
- Added a new
getWithQuery()method toRequestServiceto support passing query parameters to GET requests - Modified
DataSourceclass to include new read-only properties and customretrieve()/get()methods that accept query parameters - Added comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Service/RequestService.php | Added getWithQuery() method to support GET requests with query parameters |
| src/DataSource.php | Added new read-only properties and overridden retrieve()/get() methods to accept query parameters instead of using GetTrait |
| tests/Unit/DataSourceTest.php | Added comprehensive test suite covering all DataSource operations including the new query parameter functionality |
| README.md | Updated documentation with examples showing how to use the new query parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
843343a to
337b3ba
Compare
J-ad
approved these changes
Dec 3, 2025
swember
approved these changes
Dec 5, 2025
swember
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the List Sources and Retrieve a Source to support requesting additional fields with the following query params:
with_processing_status=truewith_auto_churn_subscription_setting=truewith_invoice_handling_setting=trueUsing SDK code:
1) List Sources
2) Retrieve a Source