Fix static analysis violations with cursor pagination#134
Open
tolry wants to merge 1 commit intochartmogul:mainfrom
Open
Fix static analysis violations with cursor pagination#134tolry wants to merge 1 commit intochartmogul:mainfrom
tolry wants to merge 1 commit intochartmogul:mainfrom
Conversation
When using cursor pagination, access to `has_more` and `cursor` are labelled as violations by phpstan or psalm, since those properties are protected on `AbstractModel` although they are readable publicly via `__get()`
sample code
```php
$cursor = null;
do {
$filter = ["customer_uuid" => $uuid];
if ($cursor) {
$filter["cursor"] = $cursor;
}
$collection = \ChartMogul\CustomerInvoices::all($filter);
foreach ($collection->invoices as $invoice) {
// do something
}
$cursor = $collection->cursor;
} while ($collection->has_more);
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using cursor pagination, access to
has_moreandcursorare labelled as violations by phpstan or psalm, since those properties are protected onAbstractModelalthough they are readable publicly via__get()sample code