Add requests timeout and retry on timeout #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds timeout and retry-on-timeout functionality to HTTP requests made via the superagent library to prevent indefinite waiting for responses.
Changes:
- Added timeout configuration with 30-second response timeout and 120-second deadline
- Added
ECONNABORTEDerror to the list of retriable errors to handle timeout scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jessicahearn
approved these changes
Jan 29, 2026
tostasqb
approved these changes
Jan 29, 2026
wscourge
deleted the
wiktor/ome-434-api-issue-with-chartmogul-node-v380
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the NPM
superagenthttp library does not timeout, and it waits indefinitely for a response.I configured it to timeout after 30 seconds (the same amount that all other SDKs do) and retry on the timeout error.