feat: update "Deploy Slurm" howto to use new node names and set-node-state#114
Merged
AshleyCliff merged 2 commits intocharmed-hpc:mainfrom Jan 29, 2026
Conversation
Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
3dc9677 to
3605239
Compare
4 tasks
3605239 to
dc30409
Compare
AshleyCliff
requested changes
Jan 27, 2026
Contributor
AshleyCliff
left a comment
There was a problem hiding this comment.
Nice work updating the language! I've tried to keep comments and suggestions on topic, there will likely be some structural updates to this page following this one.
dc30409 to
3c490d8
Compare
Member
Author
|
@AshleyCliff I've implemented your review feedback into this PR. The only thing I didn't address was your comment about providing the justification for why we need to use the constraint |
AshleyCliff
requested changes
Jan 28, 2026
Contributor
AshleyCliff
left a comment
There was a problem hiding this comment.
Looking good! Two quick tweak suggestions and then we're good to go.
Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
3c490d8 to
5361f44
Compare
Member
Author
|
@AshleyCliff this PR should be good to go now! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
Summary of Changes
This PR updates the "Deploy Slurm" how-to use the new
set-node-stateaction, and use the charm unit name as the node name rather than the machine hostname.Other changes I made include:
Related Issues, PRs, and Discussions