Skip to content

feat: update "Deploy Slurm" howto to use new node names and set-node-state#114

Merged
AshleyCliff merged 2 commits intocharmed-hpc:mainfrom
NucciTheBoss:nuccitheboss/feat/machine-hostname-to-charm-unit-name
Jan 29, 2026
Merged

feat: update "Deploy Slurm" howto to use new node names and set-node-state#114
AshleyCliff merged 2 commits intocharmed-hpc:mainfrom
NucciTheBoss:nuccitheboss/feat/machine-hostname-to-charm-unit-name

Conversation

@NucciTheBoss
Copy link
Copy Markdown
Member

Pre-submission checklist

  • I read and followed the CONTRIBUTING guidelines.
  • I have ensured that the documentation tests complete successfully.

Summary of Changes

This PR updates the "Deploy Slurm" how-to use the new set-node-state action, and use the charm unit name as the node name rather than the machine hostname.

Other changes I made include:

  1. Update the "Deploy Slurm" Terraform configuration files to use v1 of the Juju Terraform provider.
  2. Shortened the deployment instructions to be more to the point. The tutorial is where we should elaborate more on things like the importance of integrations a models.
  3. Created reusable assets for Terraform plans and admonitions that appear in multiple tabs.

Related Issues, PRs, and Discussions

Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
@NucciTheBoss NucciTheBoss requested a review from a team as a code owner January 22, 2026 18:04
@NucciTheBoss NucciTheBoss requested review from AshleyCliff and removed request for a team January 22, 2026 18:04
@NucciTheBoss NucciTheBoss self-assigned this Jan 22, 2026
@NucciTheBoss NucciTheBoss added C-slurm Component: Slurm docs This pull request makes a change to the documentation labels Jan 22, 2026
@NucciTheBoss NucciTheBoss force-pushed the nuccitheboss/feat/machine-hostname-to-charm-unit-name branch from 3dc9677 to 3605239 Compare January 22, 2026 18:05
@NucciTheBoss NucciTheBoss force-pushed the nuccitheboss/feat/machine-hostname-to-charm-unit-name branch from 3605239 to dc30409 Compare January 23, 2026 22:50
Copy link
Copy Markdown
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work updating the language! I've tried to keep comments and suggestions on topic, there will likely be some structural updates to this page following this one.

Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread reuse/howto/setup/deploy-slurm/slurm-lxd-warning.md
@NucciTheBoss NucciTheBoss force-pushed the nuccitheboss/feat/machine-hostname-to-charm-unit-name branch from dc30409 to 3c490d8 Compare January 27, 2026 21:15
@NucciTheBoss
Copy link
Copy Markdown
Member Author

@AshleyCliff I've implemented your review feedback into this PR. The only thing I didn't address was your comment about providing the justification for why we need to use the constraint virt-type=virtual-machine when deploying Slurm on LXD. I think it's better if we create a dedicated Explanation doc that explains why we recommend against deploying the Slurm charms on system containers.

Copy link
Copy Markdown
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Two quick tweak suggestions and then we're good to go.

Comment thread howto/setup/deploy-slurm.md Outdated
Comment thread howto/setup/deploy-slurm.md Outdated
Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
@NucciTheBoss NucciTheBoss force-pushed the nuccitheboss/feat/machine-hostname-to-charm-unit-name branch from 3c490d8 to 5361f44 Compare January 29, 2026 15:55
@NucciTheBoss
Copy link
Copy Markdown
Member Author

@AshleyCliff this PR should be good to go now! 👍

Copy link
Copy Markdown
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AshleyCliff AshleyCliff merged commit 40a8798 into charmed-hpc:main Jan 29, 2026
2 of 3 checks passed
@NucciTheBoss NucciTheBoss deleted the nuccitheboss/feat/machine-hostname-to-charm-unit-name branch February 9, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-slurm Component: Slurm docs This pull request makes a change to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update node name references to charm unit names

2 participants