Follow relative markdown links in the TUI pager (#441)#883
Open
aleexharris wants to merge 2 commits intocharmbracelet:masterfrom
Open
Follow relative markdown links in the TUI pager (#441)#883aleexharris wants to merge 2 commits intocharmbracelet:masterfrom
aleexharris wants to merge 2 commits intocharmbracelet:masterfrom
Conversation
aleexharris
requested review from
andreynering and
raphamorim
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses long-standing issue #441
New discussion thread #884
Add TUI pager support for following relative links to other local markdown files via:
Only follow relative links that resolve to an existing regular file within the directory Glow was opened in. Reject absolute paths, UNC/drive paths, external URLs, and root-escape attempts. Added tests for this as it is a safety concern.
PR template:
CONTRIBUTING.md.