stopwatch: default Interval to 1s in New() to match the documented default#985
Open
c-tonneslan wants to merge 1 commit into
Open
stopwatch: default Interval to 1s in New() to match the documented default#985c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The doc on Model.Interval and the New() comment both say 1s, but the zero-value time.Duration meant the ticker never advanced. Initialise it in New so the documented default actually applies. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #862.
stopwatch.New()leftIntervalat the zero-valuetime.Duration, so callingInit()immediately and never ticking, even though both the field doc and theNewcomment say it defaults to 1 second. Initialise it inNewso the documented default is what actually runs.