fix(stopwatch): wall-clock elapsed time and 1s default interval#984
Open
leno23 wants to merge 1 commit into
Open
fix(stopwatch): wall-clock elapsed time and 1s default interval#984leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Track elapsed duration from real time instead of tick count so the display stays accurate when the event loop delivers ticks late (e.g. Windows with sub-second intervals). Initialize Interval to one second as documented. Fixes charmbracelet#862 Fixes charmbracelet#237 Fixes charmbracelet/bubbletea#932
leno23
force-pushed
the
fix/stopwatch-wall-clock-and-default-interval
branch
from
313d504 to
c5f4c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intervaltotime.SecondinNew()as documented (v2: Stopwatch doesn't default to 1 second as documented #862).start+ accumulatedd) instead of addingIntervalon each tick, so the display stays accurate when ticks are delivered late (Timer and Stopwatch is not accurate #237).StartStopMsghandling to avoid duplicate tick commands.This also fixes the Windows stopwatch example where millisecond ticks batch in the event loop but real time advances normally (bubbletea#932).
Test plan
go test ./stopwatch/...Made with Cursor