fix(table): align columns with WithWidth#980
Open
leno23 wants to merge 1 commit into
Open
Conversation
WithWidth only changed the viewport width while headers and cells kept their configured column widths, causing misaligned layout and trailing padding (charmbracelet#696). Distribute or shrink column content widths so the rendered table matches the requested width, including default cell padding. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #696.
WithWidthpreviously only resized the viewport while headers and cells kept their configured column widths. That produced misaligned headers, wrapped cells, and trailing whitespace when the viewport was wider or narrower than the column sum.This PR stores the requested table width and adjusts per-column content widths (accounting for header/cell padding) so the rendered header and rows match the target width.
Test plan
go test ./table/...resize_test.gofor expand/shrink width casesWidth less than columnsgolden testNotes
Bordered cell/header styles that add extra frame size beyond padding are not fully addressed (existing TODO in tests).
Made with Cursor