fix(textinput): stop applying Text/Placeholder style to padding#973
Open
c-tonneslan wants to merge 1 commit into
Open
fix(textinput): stop applying Text/Placeholder style to padding#973c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
When Width is set, View pads the input out to that width with spaces. Both the text path and the placeholder path were running those padding spaces through the active style, so setting a background color on either Text or Placeholder caused the bg to extend well past the actual content, which doesn't match how a placeholder usually reads in CSS terms (you expect the style to scope to the text itself). Drop the styling on the padding in both code paths so the two views behave the same way: style covers the text, the rest is empty space. Closes charmbracelet#245. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245.
When Width is set, View pads the input out to that width with spaces. Both the text path and the placeholder path were running those padding spaces through the active style, so setting a background color on Text or Placeholder ended up coloring well past the actual content. The original issue notes that PlaceholderStyle looked like it scoped to just the placeholder text and TextStyle didn't, but in current main it's actually both that extend past, just in slightly different shapes.
Easiest way to make them agree: drop the styling on the padding spaces in both paths. Style now covers the text, the rest is empty.
meowgorithm called this out as the preferred direction in the issue:
Test plan
Added
TestTextStyleAndPlaceholderStyleScopeMatchwhich sets a background style on bothFocused.TextandFocused.Placeholderand checks that the padding suffix is unstyled spaces.