fix(textinput): apply missing .TextStyle to virtualCursor#967
Open
marvinlanhenke wants to merge 1 commit into
Open
fix(textinput): apply missing .TextStyle to virtualCursor#967marvinlanhenke wants to merge 1 commit into
marvinlanhenke wants to merge 1 commit into
Conversation
Author
|
Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.In
textinput.go View()we render the virtualCursor with .SetChar() set before.However, we never apply the the current
styles.Textto the.virtualCursor.TextStyle. This can lead to "punched out cells" if the textinput has a different background color set, then the terminal itself. When the cursor is blinking (hidden) the textinput background is also removed for the cursor char.This PR fixes this by setting
m.virtualCursor.TextStyle