Fix bug causing List.Width to not be respected#749
Open
ian-howell wants to merge 1 commit intocharmbracelet:masterfrom
Open
Fix bug causing List.Width to not be respected#749ian-howell wants to merge 1 commit intocharmbracelet:masterfrom
ian-howell wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
This addresses a bug when rendering Lists that causes them to ignore the `width` value provided by `New` and `SetSize`. It works by extending the existing "truncate" logic with additional padding logic to ensure that each line of text is exactly the width of the list.
|
I believe the root cause is actually the help text rendering past the list's |
New PR: #760 |
Author
|
The original issue didn't have the help message shown though... |
That's okay maybe both our PRs are needed then. Separate issues, same component. |
Author
|
@meowgorithm Sorry to bother, but could I please get a review on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug when rendering Lists that causes them to ignore the
widthvalue provided byNewandSetSize. It works by extending the existing "truncate" logic with additional padding logic to ensure that each line of text is exactly the width of the list.This addresses #744