feat(presence): implemented presence function#2123
feat(presence): implemented presence function#2123tauantcamargo wants to merge 6 commits intochar0n:masterfrom
Conversation
char0n
left a comment
There was a problem hiding this comment.
Thanks for contributing,It's looking good so far!. The PR must usually come with 5 files modified. You can see an example in this PR. This PR is missing typings and typings tests. Also please have a look at my code review comments.
|
@char0n i'll take a look to the requests, thank u by the way. |
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 234 234
Lines 622 622
=======================================
Hits 612 612
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I'm not sure I understand changes that have been made to this PR during last 3 commits. Now we should also fully utilize const presence = when(isBlank, stubNull);Notes to above implementation:
|
|
@char0n i got it .. i'll update it later .. |
|
Right, let me know if you need any assistence |
Implemented
presencefunction.Issue: #654