use container name in dictionary instead of pod's to return logs#100
Open
myroslavrozum wants to merge 1 commit intochaostoolkit:masterfrom
Open
use container name in dictionary instead of pod's to return logs#100myroslavrozum wants to merge 1 commit intochaostoolkit:masterfrom
myroslavrozum wants to merge 1 commit intochaostoolkit:masterfrom
Conversation
myroslavrozum
force-pushed
the
containerNameInsteadOfPod
branch
from
71b8b07 to
27ec6bb
Compare
Lawouach
requested changes
Sep 24, 2020
Contributor
Lawouach
left a comment
Lawouach
left a comment
There was a problem hiding this comment.
Hey there,
This is a useful change I think. But for the merge I'd need tests and changelog entries please.
And maybe a rebase from master.
myroslavrozum
force-pushed
the
containerNameInsteadOfPod
branch
from
27ec6bb to
17b4e05
Compare
Signed-off-by: Myroslav Rozum <myrosalav.rozum@gmail.com> [95] add CHANGELOG entry
myroslavrozum
force-pushed
the
containerNameInsteadOfPod
branch
from
17b4e05 to
adc4436
Compare
Author
|
Hi!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.