Conversation
ebc99aa to
c4147d8
Compare
|
Missed some things that are fixed now. Poetry.lock was rebuilt, changelog included. @jjmerchante @sduenas (mentioning you both cause I can't ask for reviews through the UI and I don't know if this got anywhere) (sorry for delay was a crazy week) |
sduenas
left a comment
There was a problem hiding this comment.
I think the PR looks ok but I'm suggesting some minor changes. Nothing related with how the code works.
4f49daa to
3c9cc93
Compare
|
The changes have been done. I can't find a way to get that poetry.lock conflict out of the way. I have remade the poetry.lock file several times and tried this: rm poetry.lock That apparently worked in the other PR but doesn't here? |
|
@alberefe can you solve the problems with the poetry.lock, please? |
35bf2b8 to
14358a5
Compare
|
There is a problem with one of the unresolved conversations, with dependencies and CI. |
a10c39e to
b7225e6
Compare
|
Okay so everything should be up! |
sduenas
left a comment
There was a problem hiding this comment.
The PR looks good to me but you are using Poetry 1.8 while we're using 2.1. Please install that version to generate the right poetry.lock file.
b7225e6 to
d545b7d
Compare
|
done |
pyproject.toml
Outdated
| "Development Status :: 5 - Production/Stable", | ||
| "Intended Audience :: Developers", | ||
| "Topic :: Software Development", | ||
| "License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)", | ||
| "Programming Language :: Python :: 3" |
There was a problem hiding this comment.
Do you know why these have one extra whitespace now?
There was a problem hiding this comment.
Well, it seems like when using the formatter it has added the same spaces as in the rest of the document where everything has 4 spaces.
Just corrected it.
poetry.lock
Outdated
| @@ -1,105 +1,240 @@ | |||
| # This file is automatically @generated by Poetry 2.3.1 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.1.0 and should not be changed by hand. | |||
There was a problem hiding this comment.
We're using 2.3.1 and this is 2.1.0. I don't mind if we use a later version, but please, don't use an older version.
There was a problem hiding this comment.
Sorry, thought I updtated to the correct one. Should be okay now.
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
d545b7d to
d3865ab
Compare
Implement credential management system with Hashicorp Vault integration. This provides automated secrets retrieval.
This relieves the user from hardcoding credentials in files and also automates the retrieval of api keys from pools in an automated way, optimizing speed when the program needs to rotate through several api keys or credentials to access different services in a row.
It follows the same idea of Bitwarden Manager class, but using other service.
The following are the contents of the PR: