Fix RabbitMQ runtime credentials#397
Open
deepanshutiwari27 wants to merge 2 commits into
Open
Conversation
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
from
624f516 to
bb4b735
Compare
MoralCode
requested changes
Jun 18, 2026
MoralCode
left a comment
MoralCode
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking on this issue! Unfortunately this is a little more complex than changing build args to environment cars because of this config file.
Happy to chat solutions if you get stuck!
Comment on lines
+27
to
+24
| RUN exec python3 update_config.py | ||
| RUN chmod +x /collectoss-rabbitmq-entrypoint.sh |
Contributor
There was a problem hiding this comment.
This won't work. This script runs at build time and is the same as the entry point script. Its going to bake a config file into the container containing a hash of the default password (because a different password isnt provided at build time)
Author
There was a problem hiding this comment.
Can we Keep the runtime wrapper, but remove RUN chmod +x and invoke it with /bin/sh. This makes config generation visibly runtime-only and keeps the image portable.
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
4 times, most recently
from
fccef95 to
bc4ed97
Compare
Signed-off-by: Deepanshu Tiwari <tiwarideepanshu235@gmail.com>
Signed-off-by: Deepanshu Tiwari <tiwarideepanshu235@gmail.com>
deepanshutiwari27
force-pushed
the
codex/fix-issue-278
branch
from
bc4ed97 to
9aab022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change rabbit mq variables from build time to runtime by changing it from args to environment variables
Fix issue #278