Re-use initialized ring queues, instead of leaking#18
Open
KvGeijer wants to merge 1 commit intochaoran:masterfrom
Open
Re-use initialized ring queues, instead of leaking#18KvGeijer wants to merge 1 commit intochaoran:masterfrom
KvGeijer wants to merge 1 commit intochaoran:masterfrom
Conversation
In the LCRQ, when another thread manages to enqueue a new ring queue with CAS before you manage, you have already initialized your RQ. Now the local one is just discarded, which leaks memory. There is infrastructure in place in the handle to save these initialized ring queues, and later re-use them in future enqueues. This commit fixes that optimization, which seems to have been broken sometime in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the LCRQ, when another thread manages to enqueue a new ring queue with CAS before you manage, you have already initialized your RQ. Now the local one is just discarded, which leaks memory.
There is infrastructure in place in the handle to save these initialized ring queues, and later re-use them in future enqueues. This commit fixes that optimization, which seems to have been broken sometime in the past.