Avoid double-free by only freeing each queue once#17
Open
KvGeijer wants to merge 1 commit intochaoran:masterfrom
Open
Avoid double-free by only freeing each queue once#17KvGeijer wants to merge 1 commit intochaoran:masterfrom
KvGeijer wants to merge 1 commit intochaoran:masterfrom
Conversation
This was mainly an issue with LCRQ, which actually implements a free function. However, this function was called from every thread when they exited, leading to a segmentation fault in many runs. Now it only lets the first thread free the queue in the benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mainly an issue with LCRQ, which actually implements a free function. However, this function was called from every thread when they exited, leading to a segmentation fault in most runs. Now it only lets a single thread free the queue in the benchmarks.