Update FBP version ^1.36.8 #39
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the flutter_blue_plus dependency from version ">=1.32.4 <1.35.0" to ^1.36.8, addressing API changes in the newer version. The update adds support for the onScanResults stream getter and incorporates new required parameters (instanceId and pin) introduced in the updated API.
Key changes:
- Updates flutter_blue_plus to ^1.36.8 and adds flutter_blue_plus_platform_interface dependency
- Implements
onScanResultsgetter with proper stream handling for Windows and other platforms - Adds
instanceIdparameter (set to 0) to Bluetooth characteristic and descriptor constructors to match new API requirements
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updates flutter_blue_plus version and adds flutter_blue_plus_platform_interface dependency |
| lib/src/wrapper/flutter_blue_plus_wrapper.dart | Adds onScanResults getter with platform-specific routing |
| lib/src/windows/windows.dart | Imports flutter_blue_plus_platform_interface for Bm* types |
| lib/src/windows/flutter_blue_plus_windows.dart | Implements onScanResults with conditional stream handling based on scanning state |
| lib/src/windows/bluetooth_device_windows.dart | Adds pin parameter to createBond method for API compatibility |
| lib/src/windows/bluetooth_characteristic_windows.dart | Adds instanceId parameter to BmBluetoothDescriptor and BmBluetoothCharacteristic constructors |
| lib/src/extension/characteristic_properties_extension.dart | Imports flutter_blue_plus_platform_interface for BmCharacteristicProperties |
| lib/src/extension/bluetooth_service_extension.dart | Imports flutter_blue_plus_platform_interface for BmBluetoothService |
| lib/src/extension/bluetooth_descriptor_extension.dart | Imports flutter_blue_plus_platform_interface and adds instanceId parameter |
| lib/src/extension/bluetooth_characteristic_extension.dart | Imports flutter_blue_plus_platform_interface and adds instanceId parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # https://pub.dev/packages/flutter_blue_plus | ||
| flutter_blue_plus: ^1.36.8 | ||
| # https://pub.dev/packages/flutter_blue_plus_platform_interface | ||
| flutter_blue_plus_platform_interface: 7.0.0 |
There was a problem hiding this comment.
The version constraint for flutter_blue_plus_platform_interface should use a caret (^) prefix or range constraint for consistency with other dependencies and to allow compatible updates. Using an exact version (7.0.0) may cause dependency resolution issues when other packages require different patch versions of the same major version.
Suggestion: Change to ^7.0.0 or ">=7.0.0 <8.0.0"
| flutter_blue_plus_platform_interface: 7.0.0 | |
| flutter_blue_plus_platform_interface: ^7.0.0 |
| Future<void> createBond({ | ||
| int timeout = 90, // TODO: implementation missing | ||
| Uint8List? pin, | ||
| }) async { |
There was a problem hiding this comment.
The pin parameter is added to match the API signature but is not used in the implementation. If WinBle.pair() doesn't support PIN-based pairing, this should be documented with a TODO comment or the parameter should be used if the underlying API supports it.
| }) async { | |
| }) async { | |
| // TODO: The 'pin' parameter is currently unused because WinBle.pair() does not support PIN-based pairing. | |
| // If WinBle adds support for PIN-based pairing in the future, update this method to use the 'pin' parameter. |
1 participant
Status
READY
Description
Type of Change