feat: use artifact.setFile to point to embedded dependency #97
+19
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It would be nice to have a test ensuring that we don't modify the |
algomaster99
force-pushed
the
push-ouosnxuuwuvr
branch
from
2070a3a to
6448c48
Compare
algomaster99
force-pushed
the
push-ouosnxuuwuvr
branch
from
6448c48 to
c424085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
artifact.setFile(destJar);API helps to not directly modify the dependencies in.m2folder.We copy the dependency into
<project>/target/classport-filesand then these dependencies are embedded.