chore: remove allow-dangling from symlink-check pipelines #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are other ways to verify the symlink like stat or readlink. the flag `--allow-absolute` is still there but I'm inclined towards not exposing it at pipelines level. If we use this at inside package config then the whole point of having a symlink-check is broken. We want to validate the integrity of fs by making sure there's no broken symlink. By exposing this, we're entering a greyish area where we're allowing this and bots are learning the same. Not exposing seems like a better default than what we had previously. Happy to discuss other thoughts here as well. Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are other ways to verify the symlink like stat or readlink.
the flag
--allow-absoluteis still there but I'm inclined towardsnot exposing it at pipelines level.
If we use this at inside package config then the whole point of having
a symlink-check is broken. We want to validate the integrity of fs
by making sure there's no broken symlink.
By exposing this, we're entering a greyish area where we're allowing
this and bots are learning the same.
Not exposing seems like a better default than what we had previously.
Happy to discuss other thoughts here as well.
Signed-off-by: kranurag7 81210977+kranurag7@users.noreply.github.com