Detect broken symlinks in the cache and fix them #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
previously approved these changes
Dec 19, 2025
markusthoemmes
commented
Dec 19, 2025
Currently, when an external process deletes a file that a symlink is pointing to in the cache, but not the symlink itself, we will never fix that and the cache will be permanently broken. This makes the `AdvertiseCachedFile` sensitive to the possibility of links being broken. Broken links are removed and the advertisement process is retried to establish a functioning cache state again.
markusthoemmes
force-pushed
the
fix-advertise
branch
from
755a653 to
e795e84
Compare
rawlingsj
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when an external process deletes a file that a symlink is pointing to in the cache, but not the symlink itself, we will never fix that and the cache will be permanently broken.
This makes the
AdvertiseCachedFilesensitive to the possibility of links being broken. Broken links are removed and the advertisement process is retried to establish a functioning cache state again.