Skip to content

Reset stale process_thread_usage series each scrape #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mempirate merged 4 commits into from
Apr 15, 2026
Merged

Reset stale process_thread_usage series each scrape #65

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab48dd2
Drop pid label from process_thread_usage
mempirate Apr 15, 2026
6cd098a
Avoid extra aggregation map for thread usage
mempirate Apr 15, 2026
e3e0277
Suffix duplicate thread names in process metrics
mempirate Apr 15, 2026
cc80cd5
Reset thread usage series before pid relabeling
mempirate Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion prometric/src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ impl ProcessCollector {

let cpu_usage = process.cpu_usage() / self.cores as f32;

// Collect thread stats
// Collect thread stats and reset the vector each scrape so exited threads do not
// leave stale PID-labelled series behind.
self.metrics.thread_usage.reset();
if let Some(tasks) = process.tasks() {
tasks.iter().for_each(|pid| {
let Some(thread) = self.sys.process(*pid) else {
Expand Down
Loading