Remove lastReadSequenceNumber.isEmpty condition to avoid infinite loop#1
Open
chadlagore wants to merge 4 commits into
Open
Remove lastReadSequenceNumber.isEmpty condition to avoid infinite loop#1chadlagore wants to merge 4 commits into
chadlagore wants to merge 4 commits into
Conversation
chadlagore
force-pushed
the
chad/remove-cond2
branch
from
4ebe3c7 to
f516168
Compare
chadlagore
force-pushed
the
chad/remove-cond2
branch
from
f516168 to
4199e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qubole#87
This fixes the problem, I need to find out if it's safe.
As a result, we never pull from empty streams for longer than
maxFetchTimeInMs.