Updated to Colour Maps 8.0#3
Open
pfuchs wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for doing this @pfuchs. I'm swamped right now with other stuff, but I will take a close look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Chadagreene,
I've taken the liberty of updating to 8.0, I've left the 7.0 files in so that it would be easy to revert in case a user wants to use the old version, but would suggest removing those files moving forward.
Let me know if there are any concerns with the modifications! I've used a slightly different approach to load the .mat files which could be more robust to additions / renaming of color maps. The "drawback" right now is that also the O version (i.e. romaO etc.) of the color maps are loaded, which weren't in the previous, and perhaps those might break other functionality.
I've checked the regular functionality of the code and it all still seemed to work with my additions!
Best wishes,
Patrick Fuchs
fixes #2