Skip to content

Updated to Colour Maps 8.0#3

Open
pfuchs wants to merge 2 commits into
chadagreene:mainfrom
pfuchs:main
Open

Updated to Colour Maps 8.0#3
pfuchs wants to merge 2 commits into
chadagreene:mainfrom
pfuchs:main

Conversation

@pfuchs
Copy link
Copy Markdown

@pfuchs pfuchs commented Jun 21, 2024

Hi Chadagreene,

I've taken the liberty of updating to 8.0, I've left the 7.0 files in so that it would be easy to revert in case a user wants to use the old version, but would suggest removing those files moving forward.

Let me know if there are any concerns with the modifications! I've used a slightly different approach to load the .mat files which could be more robust to additions / renaming of color maps. The "drawback" right now is that also the O version (i.e. romaO etc.) of the color maps are loaded, which weren't in the previous, and perhaps those might break other functionality.

I've checked the regular functionality of the code and it all still seemed to work with my additions!

Best wishes,

Patrick Fuchs

fixes #2

@chadagreene
Copy link
Copy Markdown
Owner

Thanks for doing this @pfuchs. I'm swamped right now with other stuff, but I will take a close look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update colour maps to version 8.0

2 participants