Open
Conversation
Owner
|
Sorry I had missed that this was opened, thank you for the fix. Did you run any benchmarks with this change? I’ll have to do some checks but I think the reason for page alignment was to have perfect divisions of the memory so that all the simd and usage of weights wouldn’t cross/straddle the page boundaries. I’d bet in practice it makes minimal to no difference but I’d want to check before merging. That may have been only a thing when mmaping but it’s been awhile since I’ve looked into the details. |
Author
|
Of course, thanks for your excellent work. I didn't do anything more extensive than running both versions several times with the same input. The token generation speed was basically identical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12 by avoiding page alignment in the first place.