Conversation
…anager
The cache key format was inconsistent between getConnection() and _connect(),
causing _transportsMap.remove() to fail silently during idle timeout cleanup.
- getConnection uses: '${uri.scheme}://${uri.host}:${uri.port}'
- _connect was using: '${uri.host}:${uri.port}'
This led to memory leaks as entries were never removed from _transportsMap.
Member
|
@kangqiao Good catch! Would you add a test case regarding the fix? |
- Add `cachedConnectionsCount` getter to ConnectionManager for testing - Extract `_getCacheKey` method to ensure consistent cache key format - Add test case to verify connections are properly removed after idle timeout This test validates the fix from cfug#2481 where inconsistent cache key format caused _transportsMap.remove() to fail silently, leading to memory leaks.
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes inconsistent cache key format in
_ConnectionManagerthat causes memory leak.Problem
In
connection_manager_imp.dart, the cache key format is inconsistent:getConnectiontransportCacheKeyscheme://host:porthttps://example.com:443_connectdomainhost:portexample.com:443When idle timeout fires (line 146),
_transportsMap.remove(domain)fails to find the key, causing entries to never be removed.Impact
_transportsMapentries are never cleaned upSolution
Changed
domainformat to matchtransportCacheKey:// Before
final domain = '${uri.host}:${uri.port}';
// After
final domain = '${uri.scheme}://${uri.host}:${uri.port}';