fix(native_dio_adapter): gracefully fall back when Cronet unavailable#2479
Open
DevMohammadSalameh wants to merge 1 commit intocfug:mainfrom
Open
fix(native_dio_adapter): gracefully fall back when Cronet unavailable#2479DevMohammadSalameh wants to merge 1 commit intocfug:mainfrom
DevMohammadSalameh wants to merge 1 commit intocfug:mainfrom
Conversation
Fixes cfug#2444 When Google Play Services is unavailable, CronetEngine initialization throws a JniException. This change catches the exception and falls back to the standard HttpClientAdapter using dart:io. Also adds an optional onCronetUnavailable callback for developers who want to be notified when the fallback occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2444
When Google Play Services is unavailable (e.g., on Android emulators without Google APIs or devices without Play Services),
CronetEngineinitialization throws aJniException:This change:
CronetAdaptercreation in a try-catch blockHttpClientAdapter(dart:io) when Cronet is unavailableonCronetUnavailablecallback for developers who want to be notified when the fallback occursChanges
native_adapter.dart: Added graceful fallback with try-catchCHANGELOG.md: Documented the new behaviorUsage
Test Plan
melos run format- passesmelos run analyze- passesflutter testin native_dio_adapter - all 10 tests pass