Make test_infinite_output_command more reliable#9
Merged
cfsmp3 merged 1 commit intocfsmp3:masterfrom Apr 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_infinite_output_commandis supposed to be for commands likeyes.So the use of command
yesitself fortest_infinite_output_commandseems rational butyestries as to maximize CPU usage by generating output as fast as possible in an infinite loop without any delay between repetitions.This means the test could fail or pass arbitrarily based on the CPU condition or load.
This test could be made more reliable by using a controlled loop like
bash -c "while true; do echo 'test'; sleep 0.1; done"instead ofyesfor the test in question.