Skip to content

cfengine format ./tests/acceptance/#6198

Closed
olehermanse wants to merge 5 commits into
cfengine:masterfrom
olehermanse:tests
Closed

cfengine format ./tests/acceptance/#6198
olehermanse wants to merge 5 commits into
cfengine:masterfrom
olehermanse:tests

Conversation

@olehermanse

@olehermanse olehermanse commented Jun 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@olehermanse olehermanse marked this pull request as ready for review June 26, 2026 22:14
@olehermanse

olehermanse commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins

@cf-bottom

cf-bottom commented Jun 26, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14038/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14038/

@olehermanse

olehermanse commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins, please

@cf-bottom

cf-bottom commented Jun 29, 2026

Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14055/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14055/

nickanderson
nickanderson requested changes Jun 30, 2026
View reviewed changes

@nickanderson nickanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two places where commas were removed but should not have been.

I still find the behavior of end of line comments (especially if they are last promise line) annoying.

Comment thread tests/acceptance/00_basics/01_compiler/trailing_comma_args.cf Outdated
Comment thread tests/acceptance/00_basics/01_compiler/trailing_comma_paramlist.cf
Comment thread tests/acceptance/00_basics/04_bundles/agent-bundle-class-bundle-scope-default-perspective.cf
Comment thread tests/acceptance/00_basics/04_bundles/bundle-iteration.cf
Comment thread tests/acceptance/00_basics/04_bundles/unless.cf
@olehermanse

olehermanse commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins

@olehermanse olehermanse requested a review from nickanderson June 30, 2026 21:11
@cfengine cfengine deleted a comment from cf-bottom Jun 30, 2026
@cf-bottom

cf-bottom commented Jun 30, 2026

Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14070/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14070/

nickanderson
nickanderson reviewed Jun 30, 2026
View reviewed changes
Comment thread tests/acceptance/00_basics/04_bundles/bundle-iteration.cf
@olehermanse
cfengine format ./tests/acceptance/
c1635a6 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Adjusted test expectation after formatting
fef70a8 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Manual edits after code review
6ace569 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Reworked trailing comma tests
6cea61b 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Manual edits
7306a46 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse olehermanse mentioned this pull request Jul 1, 2026
Merged
@olehermanse olehermanse closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickanderson nickanderson nickanderson approved these changes
@larsewi larsewi Awaiting requested review from larsewi

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olehermanse @cf-bottom @nickanderson